From 58ab5b33e3efe1dcd433fbe377f44402fa6ed4e1 Mon Sep 17 00:00:00 2001
From: Liam Brydon <lbry121@aucklanduni.ac.nz>
Date: Thu, 12 Feb 2026 20:20:16 +1300
Subject: [PATCH] [Fix] Filter Active Users (#314) (#329)

Adding users to a group or setting permissions on a package now filter for active users. Also any inactive members of group/package get marked as such.

<img width="490" alt="{3B906C71-F3AE-41E4-A61C-B8377D79F685}.png" src="attachments/09cf149a-9d7a-4560-8ce7-9f3487527ee2">

Reviewed-on: https://git.envipath.com/enviPath/enviPy/pulls/329
Co-authored-by: Liam Brydon <lbry121@aucklanduni.ac.nz>
Co-committed-by: Liam Brydon <lbry121@aucklanduni.ac.nz>
---
 epdb/views.py                                              | 7 +++++--
 templates/modals/objects/edit_group_member_modal.html      | 5 ++++-
 .../modals/objects/edit_package_permissions_modal.html     | 1 +
 templates/objects/group.html                               | 3 ++-
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/epdb/views.py b/epdb/views.py
index 0ffa0564..fd9aac16 100644
--- a/epdb/views.py
+++ b/epdb/views.py
@@ -1049,6 +1049,7 @@ def package(request, package_uuid):
                 "user_id", flat=True
             )
         )
+        users = users.filter(is_active=True)
 
         group_perms = GroupPackagePermission.objects.filter(package=current_package)
         groups = Group.objects.exclude(
@@ -2699,8 +2700,10 @@ def group(request, group_uuid):
 
         context["group"] = current_group
 
-        context["users"] = UserManager.get_users_lp().exclude(
-            id__in=current_group.user_member.all()
+        context["users"] = (
+            UserManager.get_users_lp()
+            .exclude(id__in=current_group.user_member.all())
+            .filter(is_active=True)
         )
         context["groups"] = (
             GroupManager.get_groups_lp()
diff --git a/templates/modals/objects/edit_group_member_modal.html b/templates/modals/objects/edit_group_member_modal.html
index 432347ff..56368e27 100644
--- a/templates/modals/objects/edit_group_member_modal.html
+++ b/templates/modals/objects/edit_group_member_modal.html
@@ -93,7 +93,10 @@
             >
               {% csrf_token %}
               <div class="flex items-center gap-2">
-                <span class="flex-1">{{ u.username }}</span>
+                <span class="flex-1"
+                  >{{ u.username }}
+                  {% if not u.is_active %}<i>(inactive)</i>{% endif %}</span
+                >
                 <input type="hidden" name="member" value="{{ u.url }}" />
                 <input type="hidden" name="action" value="remove" />
                 <button type="submit" class="btn btn-error btn-sm">
diff --git a/templates/modals/objects/edit_package_permissions_modal.html b/templates/modals/objects/edit_package_permissions_modal.html
index bf2a9fec..cc51937f 100644
--- a/templates/modals/objects/edit_package_permissions_modal.html
+++ b/templates/modals/objects/edit_package_permissions_modal.html
@@ -146,6 +146,7 @@
               <div class="grid grid-cols-12 gap-2 items-center">
                 <div class="col-span-5 truncate">
                   {{ up.user.username }}
+                  {% if not up.user.is_active %}<i>(inactive)</i>{% endif %}
                   <input
                     type="hidden"
                     name="grantee"
diff --git a/templates/objects/group.html b/templates/objects/group.html
index 8d8480bb..c689ce7f 100644
--- a/templates/objects/group.html
+++ b/templates/objects/group.html
@@ -57,7 +57,8 @@
           {% for um in group.user_member.all %}
             <li>
               <a href="{{ um.url }}" class="hover:bg-base-300"
-                >{{ um.username }}</a
+                >{{ um.username }}
+                {% if not um.is_active %}<i>(inactive)</i>{% endif %}</a
               >
             </li>
           {% endfor %}