From 8592cfae5061016084ee25749fae6ba95e5d742f Mon Sep 17 00:00:00 2001
From: jebus <lorsbach@envipath.com>
Date: Fri, 29 Aug 2025 08:09:57 +1200
Subject: [PATCH] Change how List Pages are populated (#68)

Co-authored-by: Tim Lorsbach <tim@lorsba.ch>
Reviewed-on: https://git.envipath.com/enviPath/enviPy/pulls/68
---
 epdb/views.py                           |  4 +-
 templates/collections/objects_list.html | 81 ++++++++++++++-----------
 templates/framework.html                |  6 +-
 3 files changed, 54 insertions(+), 37 deletions(-)

diff --git a/epdb/views.py b/epdb/views.py
index 0638b166..72ff30b8 100644
--- a/epdb/views.py
+++ b/epdb/views.py
@@ -1726,7 +1726,7 @@ def package_scenarios(request, package_uuid):
 
     if request.method == 'GET':
 
-        if 'application/json' in request.META.get('HTTP_ACCEPT'): #request.headers.get('Accept') == 'application/json':
+        if 'application/json' in request.META.get('HTTP_ACCEPT') and not request.GET.get('all', None):
             scens = Scenario.objects.filter(package=current_package).order_by('name')
             res = [{'name': s.name, 'url': s.url, 'uuid': s.uuid} for s in scens]
             return JsonResponse(res, safe=False)
@@ -1736,7 +1736,7 @@ def package_scenarios(request, package_uuid):
 
         context['meta']['current_package'] = current_package
         context['object_type'] = 'scenario'
-        context['breadcrumbs'] = breadcrumbs(current_package, 'pathway')
+        context['breadcrumbs'] = breadcrumbs(current_package, 'scenario')
 
         reviewed_scenario_qs = Scenario.objects.none()
         unreviewed_scenario_qs = Scenario.objects.none()
diff --git a/templates/collections/objects_list.html b/templates/collections/objects_list.html
index 16d7e13d..1423112e 100644
--- a/templates/collections/objects_list.html
+++ b/templates/collections/objects_list.html
@@ -2,27 +2,21 @@
 {% load static %}
 {% block content %}
 
-{% if reviewed_objects.count > 50 or unreviewed_objects.count > 50  %}
-{% if object_type != 'package' %}
-<div id="load-remaining-button-div">
-    <button class="btn btn-secondary btn-lg btn-block" type="button" id="load-remaining">Load all {% if reviewed_objects.count > 0 %} {{ reviewed_objects.count }} {% else %} {{ unreviewed_objects.count }} {% endif %} {{ object_type }}s
-    </button>
-    <p></p>
-    <div id="load-all-loading"></div>
-    <p></p>
-    <div id="load-all-error" style="display: none;">
-        <div class="alert alert-danger" role="alert">
-          <span class="glyphicon glyphicon-exclamation-sign" aria-hidden="true"></span>
-          <span class="sr-only">Error:</span>
-          Getting objects failed!
-        </div>
-    </div>
+    {% if object_type != 'package' %}
+        <div>
+            <div id="load-all-error" style="display: none;">
+                <div class="alert alert-danger" role="alert">
+                    <span class="glyphicon glyphicon-exclamation-sign" aria-hidden="true"></span>
+                    <span class="sr-only">Error:</span>
+                    Getting objects failed!
+                </div>
+            </div>
 
-    <input type="text" id="object-search" class="form-control" placeholder="Search by name" style="display: none;">
-    <p></p>
-</div>
-{% endif %}
-{% endif %}
+            <input type="text" id="object-search" class="form-control" placeholder="Search by name"
+                   style="display: none;">
+            <p></p>
+        </div>
+    {% endif %}
 
 {% block action_modals %}
 {% if object_type == 'package' %}
@@ -248,21 +242,34 @@
         </ul>
         {% endif %}
     </div>
+    <style>
+        .spinner-widget {
+            position: fixed; /* stays in place on scroll */
+            bottom: 20px; /* distance from bottom */
+            right: 20px; /* distance from right */
+            z-index: 9999; /* above most elements */
+            width: 60px; /* adjust to gif size */
+            height: 60px;
+        }
+
+        .spinner-widget img {
+            width: 100%;
+            height: auto;
+        }
+    </style>
+    {% if object_type != 'package' %}
+        <div id="load-all-loading" class="spinner-widget">
+            <img id="loading-gif" src="{% static '/images/wait.gif' %}" alt="Loading...">
+        </div>
+    {% endif %}
 </div>
     <script>
         $(function () {
 
-            $('#modal-form-delete-submit').on('click', function (e) {
-                e.preventDefault();
-                $('#modal-form-delete').submit();
-            });
-
             $('#object-search').show();
 
-            if ($('#load-remaining').length) {
-                $('#load-remaining').on('click', function () {
-
-                    makeLoadingGif("#load-all-loading", "{% static '/images/wait.gif' %}");
+            {% if object_type != 'package' %}
+                setTimeout(function () {
                     $('#load-all-error').hide();
 
                     $.getJSON('?all=true', function (resp) {
@@ -272,20 +279,26 @@
                         for (o in resp.objects) {
                             obj = resp.objects[o];
                             if (obj.reviewed) {
-                                $('#ReviewedContent').append('<a class="list-group-item" href="' + obj.url + '">' + obj.name + '</a>');
+                                $('#ReviewedContent').append('<a class="list-group-item" href="' + obj.url + '">' + obj.name + ' <span class="glyphicon glyphicon-star" aria-hidden="true" style="float:right" data-toggle="tooltip" data-placement="top" title="" data-original-title="Reviewed"></span></a>');
                             } else {
                                 $('#UnreviewedContent').append('<a class="list-group-item" href="' + obj.url + '">' + obj.name + '</a>');
                             }
                         }
 
-                        $('#load-all-loading').empty();
+                        $('#load-all-loading').hide();
                         $('#load-remaining').hide();
                     }).fail(function (resp) {
-                        $('#load-all-loading').empty();
+                        $('#load-all-loading').hide();
                         $('#load-all-error').show();
                     });
-                });
-            }
+
+                }, 2500);
+            {% endif %}
+
+            $('#modal-form-delete-submit').on('click', function (e) {
+                e.preventDefault();
+                $('#modal-form-delete').submit();
+            });
 
             $('#object-search').on('keyup', function () {
                 let query = $(this).val().toLowerCase();
diff --git a/templates/framework.html b/templates/framework.html
index 0cc81936..313fcdfd 100644
--- a/templates/framework.html
+++ b/templates/framework.html
@@ -3,7 +3,11 @@
 {% load static %}
 <head>
     <title>{{ title }}</title>
-
+    <style>
+        html, body {
+            overflow-x: hidden;
+        }
+    </style>
     {# TODO use bundles from bootstrap 3.3.7 #}
     <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js"></script>
     <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css">