From 94abfc90b52141ba14db1129d0f6473547f8e336 Mon Sep 17 00:00:00 2001 From: Liam Brydon <62733830+MyCreativityOutlet@users.noreply.github.com> Date: Mon, 10 Nov 2025 14:57:31 +1300 Subject: [PATCH] comments --- epdb/management/commands/bootstrap.py | 3 ++- epdb/views.py | 4 ++-- tests/views/test_package_views.py | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/epdb/management/commands/bootstrap.py b/epdb/management/commands/bootstrap.py index 3ded8bc5..d6ee1b24 100644 --- a/epdb/management/commands/bootstrap.py +++ b/epdb/management/commands/bootstrap.py @@ -170,10 +170,11 @@ class Command(BaseCommand): @transaction.atomic def handle(self, *args, **options): - # Create users + # Create licenses self.create_licenses() if options.get("only_licenses", False): return + # Create users anon, admin, g, user0 = self.create_users() self.populate_common_external_databases() diff --git a/epdb/views.py b/epdb/views.py index 25c7b886..bd183666 100644 --- a/epdb/views.py +++ b/epdb/views.py @@ -1076,11 +1076,11 @@ def package(request, package_uuid): PackageManager.update_permissions(current_user, current_package, grantee, max_perm) return redirect(current_package.url) elif cc_string is not None: - if cc_string == "no-license": + if cc_string == "no-license": # Reset the package's license current_package.license = None current_package.save() return redirect(current_package.url) - else: + else: # Get the license and assign it to the package current_package.license = License.objects.get(cc_string=cc_string) current_package.save() diff --git a/tests/views/test_package_views.py b/tests/views/test_package_views.py index e2602275..a266846a 100644 --- a/tests/views/test_package_views.py +++ b/tests/views/test_package_views.py @@ -29,7 +29,7 @@ class PackageViewTest(TestCase): add_to_group=True, is_active=True, ) - + # Create the default license set. cc_strings = ["by", "by-nc", "by-nc-nd", "by-nc-sa", "by-nd", "by-sa"] for cc_string in cc_strings: new_license = License() @@ -197,6 +197,7 @@ class PackageViewTest(TestCase): self.assertIsNone(p.license) + # Test other possible licenses cc_strings = ["by", "by-nc", "by-nc-nd", "by-nc-sa", "by-nd", "by-sa"] for cc_string in cc_strings: self.client.post(package_url, {"license": cc_string})