diff --git a/epdb/models.py b/epdb/models.py index 3db8ce0f..e0e924c1 100644 --- a/epdb/models.py +++ b/epdb/models.py @@ -2853,7 +2853,6 @@ class ApplicabilityDomain(EnviPathModel): train_instances = train_instances.with_columns(dist=pl.Series(dists)) # sort them in a descending way and take at most `self.num_neighbours` - # TODO: Should this be descending? If we want the most similar then we want values close to zero (ascending) train_instances = train_instances.sort("dist", descending=True)[:self.num_neighbours] # compute average distance rule_reliabilities[rule_uuid] = train_instances.select(pl.mean("dist")).fill_nan(0.0).item()